project-callisto / callisto-core

Report intake, escrow, matching and secure delivery code for Callisto, an online reporting system for sexual assault.
https://www.projectcallisto.org
GNU Affero General Public License v3.0
137 stars 54 forks source link

Email notification move #198

Open coilysiren opened 7 years ago

coilysiren commented 7 years ago

EmailNotification started in delivery and was eventually moved to notification. This change was definitely needed, but has the potential to cause a variety of issues. The first one I ran into is that if you are doing all of the following:

when you create new apps notification.EmailNotification won't be created properly because it's created by creating a delivery_emailnotification table and then changing that table to notification_emailnotification.

coilysiren commented 7 years ago

There's a variety of solutions to this for end users, including

A solution on callisto-core's end would be to rewrite the currently existing to a might more straightforward table creation operation for EmailNotification