Closed scattermagic closed 7 years ago
Ok, other things this PR needs to do:
Ok great. Thanks for the direction. Getting the tests in django to work took a bit of figuring out. I had to pip install a few things that were not covered by 'make app-setup', I also had to download phantomjs and put it in my .venv/bin folder. Maybe I missed a step that does all of that for you, but if not, this should be mentioned in the develop.md file somewhere. Anyway, I have the tests running now, so I will take a shot at adding the text area to wizard builder
On 13 October 2017 at 12:40, Lynn Cyrin notifications@github.com wrote:
Ok, other things this PR needs to do:
- add the model to admin https://github.com/project- callisto/django-wizard-builder/blob/96a12c322234927b8d77c18984acc7 bbe4adb7a2/wizard_builder/admin/init.py https://github.com/project-callisto/django-wizard-builder/blob/96a12c322234927b8d77c18984acc7bbe4adb7a2/wizard_builder/admin/__init__.py
- add an inheritance test https://github.com/project- callisto/django-wizard-builder/blob/9eef126644ac63017b3a3fd0713dcf bfb152061f/wizard_builder/tests/test_inheritance.py https://github.com/project-callisto/django-wizard-builder/blob/9eef126644ac63017b3a3fd0713dcfbfb152061f/wizard_builder/tests/test_inheritance.py
- add an admin test https://github.com/project-callisto/django-wizard- builder/blob/96a12c322234927b8d77c18984acc7bbe4adb7a2/wizard_builder/ tests/test_admin.py https://github.com/project-callisto/django-wizard-builder/blob/96a12c322234927b8d77c18984acc7bbe4adb7a2/wizard_builder/tests/test_admin.py
- be added to the text answer types https://github.com/project- callisto/django-wizard-builder/blob/97572b0ec47cedf848a3ade0b4dddb 19764464e8/wizard_builder/view_helpers.py#L61 https://github.com/project-callisto/django-wizard-builder/blob/97572b0ec47cedf848a3ade0b4dddb19764464e8/wizard_builder/view_helpers.py#L61
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/project-callisto/django-wizard-builder/pull/185#issuecomment-336535118, or mute the thread https://github.com/notifications/unsubscribe-auth/AfBYoeaLrm_bjcmejiTy39VyEkER9-nGks5sr66igaJpZM4P2Kff .
@scattermagic
had to pip install a few things
perhaps this is addressed by https://github.com/project-callisto/django-wizard-builder/pull/190/commits/085a8f20a5f403a64d788eab52952c7a63820798 ?
had to download phantomjs
There's probably a few extra steps to the installation for phantomjs (than what my readme add hints at) but I'll leave it there for now
This is definitely that start, though quite a few more things would need to happen to get the text area rendering and saving in forms. I'll outline them later today