project-chip / certification-tool

A test harness and tooling designed to simplify development, testing, and certification for devices, guided by the Connectivity Standards Alliance.
https://csa-iot.org/
Apache License 2.0
27 stars 13 forks source link

[Bug] TC-VALCC-3.1 step 4 and 7 state that CurrentState attribute should be read continuously but it is not. #207

Closed CoekaertsJasper closed 3 months ago

CoekaertsJasper commented 4 months ago

Describe the bug

CurrentState attribute is only read at open or close but not continuously.

Steps to reproduce the behavior

This occurs always when running the Python script.

Expected behavior

CurrentState Should also read transitioning state.

Log files

No response

PICS file

No response

Screenshots

No response

Environment

No response

Additional Information

No response

CoekaertsJasper commented 4 months ago

TC-VALCC_3-1_2024_03_05_Python_TH.log

ReneJosefsen commented 4 months ago

Does the device support transitioning over time? the script keeps reading while the state is transitioning, once it hits Open or Close, depending on the test step it breaks and continues to the next step. So if the DUT go directly to Open or Close state, then it should not read continuously?

ReneJosefsen commented 4 months ago

Looking at the look, it does indeed look like the current state jumps directly to the Open or Closed state, which is totally legal to do, but it does mean that the test will simply just do a single read and determine that it has reached the expected state. There is no reason to keep reading, the continuous part is to handle valves with a transition time.

I would argue that this is not an issue and the tests passes as expected.

raju-apple commented 4 months ago

Sounds good , @ReneJosefsen can we close this issue or do we want to get it clarified with the test plan folks ?

ReneJosefsen commented 4 months ago

We can circle this around the TP group, but FWIW I did both the test plans and the scrips so it will properly be me answering there as well 😅

ReneJosefsen commented 3 months ago

My take is that this is "as designed" and we can close this.