search

project-chip / certification-tool

A test harness and tooling designed to simplify development, testing, and certification for devices, guided by the Connectivity Standards Alliance.
https://csa-iot.org/
Apache License 2.0
38 stars 22 forks source link

[Bug] Wrong validation of bit mask #303

Open lecndav opened 3 months ago

lecndav commented 3 months ago

Describe the bug

The check for the feature map of the TC-OO-1.1 Step 3a results in a false negative. Error: The response (0x1) match the masks: ['0x1']

I suspect that for whatever reason the check is done against a string?

Steps to reproduce the behavior

Run the TC-00-1.1 test with the lightning feature enabled against an endpoint which implements the OnOff cluster

Expected behavior

The test should pass

Log files

TH: INFO | 2024-06-06 07:38:06.283927 | Executing Test Step: Step 3a: Given OO.S.F00(LT) ensure featuremap has the correct bit set CHIPTOOL | 2024-06-06 07:38:06.596016 | CHIP:TOO Command: onoff read feature-map 0xa7012199bd2dc19d 9 CHIPTOOL | 2024-06-06 07:38:06.599351 | CHIP:TOO Sending command to node 0xa7012199bd2dc19d CHIPTOOL | 2024-06-06 07:38:06.601356 | CHIP:CSM FindOrEstablishSession: PeerId = [1:A7012199BD2DC19D] CHIPTOOL | 2024-06-06 07:38:06.603466 | CHIP:CSM FindOrEstablishSession: No existing OperationalSessionSetup instance found CHIPTOOL | 2024-06-06 07:38:06.605582 | CHIP:DIS Found an existing secure session to [1:A7012199BD2DC19D]! CHIPTOOL | 2024-06-06 07:38:06.607599 | CHIP:DIS OperationalSessionSetup[1:A7012199BD2DC19D]: State change 1 --> 5 CHIPTOOL | 2024-06-06 07:38:06.608899 | CHIP:TOO Sending ReadAttribute to: CHIPTOOL | 2024-06-06 07:38:06.609841 | CHIP:TOO cluster 0x0000_0006, attribute: 0x0000_FFFC, endpoint 9 CHIPTOOL | 2024-06-06 07:38:06.611450 | CHIP:DMG SendReadRequest ReadClient[0xffff880660b0]: Sending Read Request CHIPTOOL | 2024-06-06 07:38:06.612585 | CHIP:DMG >> to UDP:[fd6b:c22e:8b1c:af42:430:6cf2:4156:d07%wlan0]:5540 | 152593291 | [Interaction Model (1) / Read Request (0x02) / Session = 43864 / Exchange = 55121] CHIPTOOL | 2024-06-06 07:38:06.613521 | CHIP:DMG Header Flags = CHIPTOOL | 2024-06-06 07:38:06.614413 | CHIP:DMG { CHIPTOOL | 2024-06-06 07:38:06.615299 | CHIP:DMG Exchange (0x05) = CHIPTOOL | 2024-06-06 07:38:06.616228 | CHIP:DMG { CHIPTOOL | 2024-06-06 07:38:06.617197 | CHIP:DMG Initiator = true CHIPTOOL | 2024-06-06 07:38:06.618653 | CHIP:DMG NeedsAck = true CHIPTOOL | 2024-06-06 07:38:06.619700 | CHIP:DMG } CHIPTOOL | 2024-06-06 07:38:06.620671 | CHIP:DMG } CHIPTOOL | 2024-06-06 07:38:06.621566 | CHIP:DMG
CHIPTOOL | 2024-06-06 07:38:06.622443 | CHIP:DMG Decrypted Payload (22 bytes) = CHIPTOOL | 2024-06-06 07:38:06.623308 | CHIP:DMG { CHIPTOOL | 2024-06-06 07:38:06.624205 | CHIP:DMG data = 153600172402092403062504fcff1818290324ff0b18 CHIPTOOL | 2024-06-06 07:38:06.625111 | CHIP:DMG } CHIPTOOL | 2024-06-06 07:38:06.625989 | CHIP:DMG
CHIPTOOL | 2024-06-06 07:38:06.626853 | CHIP:DMG ReadRequestMessage = CHIPTOOL | 2024-06-06 07:38:06.627723 | CHIP:DMG { CHIPTOOL | 2024-06-06 07:38:06.628669 | CHIP:DMG AttributePathIBs = CHIPTOOL | 2024-06-06 07:38:06.629577 | CHIP:DMG [ CHIPTOOL | 2024-06-06 07:38:06.630447 | CHIP:DMG AttributePathIB = CHIPTOOL | 2024-06-06 07:38:06.631301 | CHIP:DMG { CHIPTOOL | 2024-06-06 07:38:06.632178 | CHIP:DMG Endpoint = 0x9, CHIPTOOL | 2024-06-06 07:38:06.633061 | CHIP:DMG Cluster = 0x6, CHIPTOOL | 2024-06-06 07:38:06.633926 | CHIP:DMG Attribute = 0x0000_FFFC, CHIPTOOL | 2024-06-06 07:38:06.634780 | CHIP:DMG } CHIPTOOL | 2024-06-06 07:38:06.635624 | CHIP:DMG
CHIPTOOL | 2024-06-06 07:38:06.636535 | CHIP:DMG ], CHIPTOOL | 2024-06-06 07:38:06.637407 | CHIP:DMG
CHIPTOOL | 2024-06-06 07:38:06.638266 | CHIP:DMG isFabricFiltered = true, CHIPTOOL | 2024-06-06 07:38:06.639120 | CHIP:DMG InteractionModelRevision = 11 CHIPTOOL | 2024-06-06 07:38:06.639978 | CHIP:DMG }, CHIPTOOL | 2024-06-06 07:38:06.640883 | CHIP:DMG
CHIPTOOL | 2024-06-06 07:38:06.641739 | CHIP:DMG Additional Fields = CHIPTOOL | 2024-06-06 07:38:06.642589 | CHIP:DMG { CHIPTOOL | 2024-06-06 07:38:06.643444 | CHIP:DMG peer_address = UDP:[fd6b:c22e:8b1c:af42:430:6cf2:4156:d07%wlan0]:5540 CHIPTOOL | 2024-06-06 07:38:06.644338 | CHIP:DMG } CHIPTOOL | 2024-06-06 07:38:06.645208 | CHIP:DMG
CHIPTOOL | 2024-06-06 07:38:06.646047 | CHIP:EM <<< [E:55121i S:62893 M:152593291] (S) Msg TX to 1:A7012199BD2DC19D [D158] [UDP:[fd6b:c22e:8b1c:af42:430:6cf2:4156:d07%wlan0]:5540] --- Type 0001:02 (IM:ReadRequest) CHIPTOOL | 2024-06-06 07:38:06.646912 | CHIP:DMG MoveToState ReadClient[0xffff880660b0]: Moving to [AwaitingIn] CHIPTOOL | 2024-06-06 07:38:06.647762 | CHIP:DMG << from UDP:[fd6b:c22e:8b1c:af42:430:6cf2:4156:d07%wlan0]:5540 | 189879866 | [Interaction Model (1) / Report Data (0x05) / Session = 62893 / Exchange = 55121] CHIPTOOL | 2024-06-06 07:38:06.648670 | CHIP:DMG Header Flags = CHIPTOOL | 2024-06-06 07:38:06.651390 | CHIP:DMG { CHIPTOOL | 2024-06-06 07:38:06.652493 | CHIP:DMG Exchange (0x06) = CHIPTOOL | 2024-06-06 07:38:06.653407 | CHIP:DMG { CHIPTOOL | 2024-06-06 07:38:06.654275 | CHIP:DMG AckMsg = 152593291 CHIPTOOL | 2024-06-06 07:38:06.655160 | CHIP:DMG NeedsAck = true CHIPTOOL | 2024-06-06 07:38:06.656027 | CHIP:DMG } CHIPTOOL | 2024-06-06 07:38:06.656942 | CHIP:DMG } CHIPTOOL | 2024-06-06 07:38:06.657795 | CHIP:DMG
CHIPTOOL | 2024-06-06 07:38:06.658659 | CHIP:DMG Decrypted Payload (37 bytes) = CHIPTOOL | 2024-06-06 07:38:06.659526 | CHIP:DMG { CHIPTOOL | 2024-06-06 07:38:06.660447 | CHIP:DMG data = 15360115350126009837890337012402092403062504fcff18240201181818290424ff0b18 CHIPTOOL | 2024-06-06 07:38:06.661342 | CHIP:DMG } CHIPTOOL | 2024-06-06 07:38:06.662209 | CHIP:DMG
CHIPTOOL | 2024-06-06 07:38:06.663059 | CHIP:DMG
CHIPTOOL | 2024-06-06 07:38:06.663901 | CHIP:DMG Additional Fields = CHIPTOOL | 2024-06-06 07:38:06.664799 | CHIP:DMG { CHIPTOOL | 2024-06-06 07:38:06.666308 | CHIP:DMG peer_address = UDP:[fd6b:c22e:8b1c:af42:430:6cf2:4156:d07%wlan0]:5540 CHIPTOOL | 2024-06-06 07:38:06.667340 | CHIP:DMG } CHIPTOOL | 2024-06-06 07:38:06.668275 | CHIP:DMG
CHIPTOOL | 2024-06-06 07:38:06.669209 | CHIP:EM >>> [E:55121i S:62893 M:189879866 (Ack:152593291)] (S) Msg RX from 1:A7012199BD2DC19D [D158] --- Type 0001:05 (IM:ReportData) CHIPTOOL | 2024-06-06 07:38:06.671628 | CHIP:EM Found matching exchange: 55121i, Delegate: 0xffff880660c0 CHIPTOOL | 2024-06-06 07:38:06.672707 | CHIP:EM Rxd Ack; Removing MessageCounter:152593291 from Retrans Table on exchange 55121i CHIPTOOL | 2024-06-06 07:38:06.673634 | CHIP:DMG ReportDataMessage = CHIPTOOL | 2024-06-06 07:38:06.677585 | CHIP:DMG { CHIPTOOL | 2024-06-06 07:38:06.678627 | CHIP:DMG AttributeReportIBs = CHIPTOOL | 2024-06-06 07:38:06.679533 | CHIP:DMG [ CHIPTOOL | 2024-06-06 07:38:06.680488 | CHIP:DMG AttributeReportIB = CHIPTOOL | 2024-06-06 07:38:06.682914 | CHIP:DMG { CHIPTOOL | 2024-06-06 07:38:06.683982 | CHIP:DMG AttributeDataIB = CHIPTOOL | 2024-06-06 07:38:06.684938 | CHIP:DMG { CHIPTOOL | 2024-06-06 07:38:06.685811 | CHIP:DMG DataVersion = 0x3893798, CHIPTOOL | 2024-06-06 07:38:06.688342 | CHIP:DMG AttributePathIB = CHIPTOOL | 2024-06-06 07:38:06.689384 | CHIP:DMG { CHIPTOOL | 2024-06-06 07:38:06.690299 | CHIP:DMG Endpoint = 0x9, CHIPTOOL | 2024-06-06 07:38:06.691176 | CHIP:DMG Cluster = 0x6, CHIPTOOL | 2024-06-06 07:38:06.694079 | CHIP:DMG Attribute = 0x0000_FFFC, CHIPTOOL | 2024-06-06 07:38:06.695130 | CHIP:DMG } CHIPTOOL | 2024-06-06 07:38:06.696036 | CHIP:DMG
CHIPTOOL | 2024-06-06 07:38:06.697013 | CHIP:DMG Data = 1, CHIPTOOL | 2024-06-06 07:38:06.699891 | CHIP:DMG }, CHIPTOOL | 2024-06-06 07:38:06.700977 | CHIP:DMG
CHIPTOOL | 2024-06-06 07:38:06.701900 | CHIP:DMG }, CHIPTOOL | 2024-06-06 07:38:06.702784 | CHIP:DMG
CHIPTOOL | 2024-06-06 07:38:06.705425 | CHIP:DMG ], CHIPTOOL | 2024-06-06 07:38:06.706446 | CHIP:DMG
CHIPTOOL | 2024-06-06 07:38:06.707340 | CHIP:DMG SuppressResponse = true, CHIPTOOL | 2024-06-06 07:38:06.708279 | CHIP:DMG InteractionModelRevision = 11 CHIPTOOL | 2024-06-06 07:38:06.712198 | CHIP:DMG } CHIPTOOL | 2024-06-06 07:38:06.713277 | CHIP:TOO Endpoint: 9 Cluster: 0x0000_0006 Attribute 0x0000_FFFC DataVersion: 59324312 CHIPTOOL | 2024-06-06 07:38:06.714194 | CHIP:TOO FeatureMap: 1 CHIPTOOL | 2024-06-06 07:38:06.715070 | CHIP:DMG >> to UDP:[fd6b:c22e:8b1c:af42:430:6cf2:4156:d07%wlan0]:5540 | 152593292 | [Secure Channel (0) / Standalone Ack (0x10) / Session = 43864 / Exchange = 55121] CHIPTOOL | 2024-06-06 07:38:06.717446 | CHIP:DMG Header Flags = CHIPTOOL | 2024-06-06 07:38:06.718523 | CHIP:DMG { CHIPTOOL | 2024-06-06 07:38:06.719493 | CHIP:DMG Exchange (0x03) = CHIPTOOL | 2024-06-06 07:38:06.722996 | CHIP:DMG { CHIPTOOL | 2024-06-06 07:38:06.724050 | CHIP:DMG Initiator = true CHIPTOOL | 2024-06-06 07:38:06.725071 | CHIP:DMG AckMsg = 189879866 CHIPTOOL | 2024-06-06 07:38:06.725966 | CHIP:DMG } CHIPTOOL | 2024-06-06 07:38:06.732758 | CHIP:DMG } CHIPTOOL | 2024-06-06 07:38:06.733812 | CHIP:DMG
CHIPTOOL | 2024-06-06 07:38:06.734718 | CHIP:DMG Additional Fields = CHIPTOOL | 2024-06-06 07:38:06.735602 | CHIP:DMG { CHIPTOOL | 2024-06-06 07:38:06.738698 | CHIP:DMG peer_address = UDP:[fd6b:c22e:8b1c:af42:430:6cf2:4156:d07%wlan0]:5540 CHIPTOOL | 2024-06-06 07:38:06.739724 | CHIP:DMG } CHIPTOOL | 2024-06-06 07:38:06.740704 | CHIP:DMG
CHIPTOOL | 2024-06-06 07:38:06.741616 | CHIP:EM <<< [E:55121i S:62893 M:152593292 (Ack:189879866)] (S) Msg TX to 1:A7012199BD2DC19D [D158] [UDP:[fd6b:c22e:8b1c:af42:430:6cf2:4156:d07%wlan0]:5540] --- Type 0000:10 (SecureChannel:StandaloneAck) CHIPTOOL | 2024-06-06 07:38:06.743171 | CHIP:EM Flushed pending ack for MessageCounter:189879866 on exchange 55121i WARNING | 2024-06-06 07:38:06.744195 | Test Failure: The response (0x1) match the masks: ['0x1']. INFO | 2024-06-06 07:38:06.745660 | Test Step Completed [FAILED]: Step 3a: Given OO.S.F00(LT) ensure featuremap has the correct bit set

PICS file

No response

Screenshots

No response

Environment

Additional Information

No response