search

project-chip / connectedhomeip

Matter (formerly Project CHIP) creates more connections between more objects, simplifying development for manufacturers and increasing compatibility for consumers, guided by the Connectivity Standards Alliance.
https://buildwithmatter.com
Apache License 2.0
7.5k stars 2.01k forks source link

HWADR not supported yet #14075

Open woody-apple opened 2 years ago

woody-apple commented 2 years ago

false

https://github.com/project-chip/connectedhomeip/blob/f0f5de0d79ae1c51d7fddbf70900ebac0acd899a/src/app/zap-templates/zcl/data-model/chip/general-diagnostics-cluster.xml#L74-L79

This issue was generated by todo-issue based on a TODO comment in f0f5de0d79ae1c51d7fddbf70900ebac0acd899a.
bzbarsky-apple commented 2 years ago

@yufengwangca

bzbarsky-apple commented 2 years ago

Might not be worth fixing this for 1.0. The actual code and spec-observable behavior is correct. So the only change to be made here would be to use hwadr in the XML and then plumb though all the codegen bits to make the code come out exactly the same in the end.

Unless we want a non-ByteSpan representation of this on the C++ side, of course, but it's not clear that we want that.

woody-apple commented 2 years ago

SDK Spec Review: We do not believe this is a spec compliance issue.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.