search

project-chip / connectedhomeip

Matter (formerly Project CHIP) creates more connections between more objects, simplifying development for manufacturers and increasing compatibility for consumers, guided by the Connectivity Standards Alliance.
https://buildwithmatter.com
Apache License 2.0
7.5k stars 2.01k forks source link

Minimal mdns will not notify upper layer when discovery timeout. #15071

Open erjiaqing opened 2 years ago

erjiaqing commented 2 years ago

Problem

https://github.com/project-chip/connectedhomeip/blob/e02fd6022c5808ba50ae4f4fb556553168c2277c/src/lib/dnssd/minimal_mdns/ActiveResolveAttempts.cpp#L171-L176

The discovery will fail silently when timeout, however, the Dnssd::ResolverDelegate is waiting for a OnNodeIdResolutionFailed callback.

Proposed Solution

Call Dnssd::ResolverDelegate::OnNodeIdResolutionFailed when removing a nodeid form the queue.

bzbarsky-apple commented 2 years ago

@erjiaqing @andy31415 Is this still an issue?

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] commented 1 year ago

This stale issue has been automatically closed. Thank you for your contributions.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.