project-chip / connectedhomeip

Matter (formerly Project CHIP) creates more connections between more objects, simplifying development for manufacturers and increasing compatibility for consumers, guided by the Connectivity Standards Alliance.
https://buildwithmatter.com
Apache License 2.0
7.56k stars 2.04k forks source link

Some remaining session resumption issues #17468

Open bzbarsky-apple opened 2 years ago

bzbarsky-apple commented 2 years ago

Problem

17153 was closed without addressing all the issues it mentions. Remaining:

@kghost

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

woody-apple commented 2 years ago

Issue Scrub: Moving to 1.X. Would be good to find an owner for v1.1

msandstedt commented 2 years ago

The state for a fabric is not cleaned out when the fabric is removed. This is probably OK because in practice it will just get ignored when it does not match new connection attempts, but it's a little weird.

This is complete.

The storage situation is a bit odd: we are storing fabric-specific state in global across-fabrics buckets/ Ideally we would store all this under per-fabric keys.

This can be implemented by any who choose to implement and inject their own session resumption storage, so the SDK does not preclude it.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.