project-chip / connectedhomeip

Matter (formerly Project CHIP) creates more connections between more objects, simplifying development for manufacturers and increasing compatibility for consumers, guided by the Connectivity Standards Alliance.
https://buildwithmatter.com
Apache License 2.0
7.47k stars 2k forks source link

Cannot override DeviceAttestationVerifier in Darwin commissioning flow #18445

Closed tcarmelveilleux closed 1 year ago

tcarmelveilleux commented 2 years ago

Problem

The API surface for Darwin commissioning flows prevents passing a Device Attestation Verifier equivalent that would allow arbitrary policy checks, and allow aggregation/saving of the DAC cert chain and attestation elements/signature, which are needed to do an end-to-end attestation flow if the CA resides off the device (e.g. if running a custom fabric in a multi-fabric situation with app on iOS with Matter framework). Similarly, this prevents having rules that simplify the usage/trust of development device attesattion credentials in a given fabric, where additional rules or validations may be needed.

Proposed Solution

bzbarsky-apple commented 2 years ago

@anush-apple @woody-apple FYI.

woody-apple commented 2 years ago

@tcarmelveilleux Can you provide an example API that would fit the needs here?

woody-apple commented 2 years ago

@tcarmelveilleux Anything remaining here that's needed? If so, we can move back into 1.0.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

woody-apple commented 1 year ago

@tcarmelveilleux I believe the API needed is now complete, and working, correct? Please re-open if needed.