search

project-chip / connectedhomeip

Matter (formerly Project CHIP) creates more connections between more objects, simplifying development for manufacturers and increasing compatibility for consumers, guided by the Connectivity Standards Alliance.
https://buildwithmatter.com
Apache License 2.0
7.55k stars 2.04k forks source link

lighting-app has occupancy sensing server cluster #19116

Open fessehaeve opened 2 years ago

fessehaeve commented 2 years ago

Problem

According to spec OnOffLight device type has occupancy sensing client cluster as optional. Having the server cluster here seems wrong.

Proposed Solution

Replace occupancy sensing server with client.

bzbarsky-apple commented 2 years ago

If this is done, Binding also needs to be added on the endpoint, since it will then have a client cluster.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

jvmahon commented 10 months ago

It seems odd to have an optional Occupancy Sensing cluster for On/Off Light type 0x0100 and Dimmable Light 0x0101. Shouldn't Occupancy Sensing just be done as a separate endpoint? Also seems odd to include it in the Pump type as a Optional cluster rather than as a separate endpoint.

Note that it also seems inconsistent (why is it on those two light types but not Color Temperature Light 0x010C and Extended Color Light 0x010D). Seems that implementing as a separate endpoint when needed would be more consistent.