Address review comments on PR 20031

project-chip / connectedhomeip

Matter (formerly Project CHIP) creates more connections between more objects, simplifying development for manufacturers and increasing compatibility for consumers, guided by the Connectivity Standards Alliance.

https://buildwithmatter.com

Apache License 2.0

7.56k stars 2.04k forks source link

Address review comments on PR 20031 #20081

Open bzbarsky-apple opened 2 years ago

bzbarsky-apple commented 2 years ago

Problem

Inconsistent handling of clusters, device XML not matching device specs.

See https://github.com/project-chip/connectedhomeip/pull/20031#pullrequestreview-1022082631

Proposed Solution

Fix it.

@markus-becker-tridonic-com

andy31415 commented 2 years ago

Removed v1.0 tag since the PR references scenes cluster.

woody-apple commented 2 years ago

Spec Review: Scenes are provisional for v1.0, however the XML does not match that. Marking v1.0.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.