[Platform] LayerImplFreeRTOS::StartPlatformTimer return value is never checked

[bzbarsky-apple]

Reproduction steps / Feature

1. Call System::Layer::StartTimer on a FreeRTOS platform before calling PlatformManager::InitChipStack (like TestSystemTimer.cpp does).
2. The call succeeds, even though the actual event that would cause the timer to fire has not been scheduled. This is because nothing checks the return value of LayerImplFreeRTOS::StartPlatformTimer.

What should probably happen here is:

• Add the missing checks.
• Fix the test to actually run the platform manager event loop.
• Fix things so the platform manager event loop can notice the changes to the system clock the test makes.

Platform

freeRTOS

Platform Version(s)

No response

Type

Manually tested with SDK

(Optional) If manually tested please explain why this is only manually tested

The unit tests have a workaround for this, as described above.

Anything else?

No response

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.