project-chip / connectedhomeip

Matter (formerly Project CHIP) creates more connections between more objects, simplifying development for manufacturers and increasing compatibility for consumers, guided by the Connectivity Standards Alliance.
https://buildwithmatter.com
Apache License 2.0
7.39k stars 1.98k forks source link

Remove stale bot #24571

Open ShadowJonathan opened 1 year ago

ShadowJonathan commented 1 year ago

I want to ask to remove the stale bot from this repo, it will not serve any comprehensive purpose for the long term of this project;

There is no excuse for a stale bot to be in this repo.

bzbarsky-apple commented 1 year ago

@andy31415 @woody-apple

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

ShadowJonathan commented 1 year ago

No.

ShadowJonathan commented 1 year ago

@andy31415 @woody-apple @bzbarsky-apple

andy31415 commented 1 year ago

I am torn on this one - when we have a lot of issues open, old ones tend to be not looked at (seems to happen the same with PRs unfortunately). As a result, only issues with traffic (even if not that informative "still happening in the latest master SHA) actually get looked at.

In my mind issue count is absolutely not a metric, however we also need some way to assess what issues are still happening and important. As a developer it can be frustrating to look to fix an issue only to find out it is not reproducible anymore (or wrongly assume it is not by testing just a few times however test environment having changed).

Any suggestions on approaches? Ideally I would want a smarter bot - clear issue reports to be kept open while actually potentially stale issues (vague reproduction, people having looked at them and never again) to actually get obsoleted.

ShadowJonathan commented 1 year ago

That might be a good compromise, but please make sure your issue triage process makes sure that no issues fall through the cracks.

For instance, issues that haven't gotten to triage yet. That situation is understandable when developers are overworked and can't handle everything, but issues shouldn't languish, it should be FIFO. Issues (imo) may be gotten stale if the response depends on the issuer, such as when devs are waiting for better reproduction info, and if a few months pass by without the author getting to it, it almost certainly has fallen through.

However, when issues are confirmed reproduced, they should get labels that would prevent stale bots from reaping them, and a developer could go through and try to reproduce it again, to see if the issue still exists.

But only through that way should an well-defined issue in progress get closed for staleness; manually.