search

project-chip / connectedhomeip

Matter (formerly Project CHIP) creates more connections between more objects, simplifying development for manufacturers and increasing compatibility for consumers, guided by the Connectivity Standards Alliance.
https://buildwithmatter.com
Apache License 2.0
7.17k stars 1.9k forks source link

[Platform][Silabs][WIFI] Security types still do not match spec #25500

Open bzbarsky-apple opened 1 year ago

bzbarsky-apple commented 1 year ago

The fix for https://github.com/project-chip/connectedhomeip/issues/25118 wasn't right, as far as I can tell. It's mixing up the scan result security type (which is a bitmap) and the wifi diagnostic security type (which is an enum). See https://github.com/project-chip/connectedhomeip/pull/25458#pullrequestreview-1327200565

@rosahay-silabs @jmartinez-silabs

bzbarsky-apple commented 1 year ago

@jmeg-sfy

rosahay-silabs commented 1 year ago

@bzbarsky-apple I have replied to your comments, let's take this conversation on slack and once concluded we can post the outcome here and open a PR if required.

jmeg-sfy commented 1 year ago

@bzbarsky-apple thanks for catching this up!

stale[bot] commented 8 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.