[1.2] Address review comments on commissioning time sync code

project-chip / connectedhomeip

Matter (formerly Project CHIP) creates more connections between more objects, simplifying development for manufacturers and increasing compatibility for consumers, guided by the Connectivity Standards Alliance.

Apache License 2.0

7.48k stars 2.01k forks source link

Reproduction steps

See https://github.com/project-chip/connectedhomeip/pull/27812#pullrequestreview-1540097503

There are a few issues:

[x] I think the kCheckForMatchingFabric bits got broken
[x] I don't think TrustedTimeSource is being set correctly. [Being addressed in https://github.com/project-chip/connectedhomeip/pull/28284 ]
[ ] The ComissioningParameters handling has use-after-free issues.

Bug prevalence

always

GitHub hash of the SDK that was being used

ac3535b

Platform

core

Platform Version(s)

No response

Type

Security Issue

Anything else?