project-chip / connectedhomeip

Matter (formerly Project CHIP) creates more connections between more objects, simplifying development for manufacturers and increasing compatibility for consumers, guided by the Connectivity Standards Alliance.
https://buildwithmatter.com
Apache License 2.0
7.39k stars 1.98k forks source link

[1.3] Boolean State Cluster XML has to be updated as per spec #30367

Open Saravana-kr22 opened 10 months ago

Saravana-kr22 commented 10 months ago

Description:

As per the spec the StateChange event is optional , Hence in the XML file this should have optional="true" , But it is missing in the XML.

Spec reference:

image

XML Reference: https://github.com/project-chip/connectedhomeip/blob/master/src/app/zap-templates/zcl/data-model/chip/boolean-state-cluster.xml

Bug prevalence

Whenever I do this

GitHub hash of the SDK that was being used

eb2f8f6ca95c181577415bc4b3e7cc240d5b2edd

Platform

raspi

Platform Version(s)

RPI - 4, 8GB RAM

Type

Test Improvement

Anything else?

No response

bzbarsky-apple commented 10 months ago

@Saravana-kr22 See https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/6270

ReneJosefsen commented 8 months ago

The water management effort is a "consumer" of the Boolean State cluster, but I'm not sure this should be marked in the Water Management project 🤔

ReneJosefsen commented 8 months ago

A spec PR has been raised to make it clear the the event is optional, so I assume we need to get optional="true" added to the XML.