search

project-chip / connectedhomeip

Matter (formerly Project CHIP) creates more connections between more objects, simplifying development for manufacturers and increasing compatibility for consumers, guided by the Connectivity Standards Alliance.
https://buildwithmatter.com
Apache License 2.0
7.5k stars 2.01k forks source link

[Test Failed] EWATERHRT1.1: Failure return on reading Feature-Map and Cluster Revision attribute. #34977

Closed jadhavrohit924 closed 2 months ago

jadhavrohit924 commented 3 months ago

Test issue(s)

DUT returned failure when a read command was sent from the controller for feature-map and cluster-revision attributes.

Platform

No response

Anything else?

chip_tool.txt device.txt

jamesharrow commented 3 months ago

This was on ESP32 all-clusters-app - so maybe the cluster isn't correctly configure in ZAP to say where these two attributes come from?

bzbarsky-apple commented 2 months ago

@jamesharrow The ZAP part is fine. It's just that Clusters::WaterHeaterManagement::WhmApplicationInit happens only in all-clusters-app/linux/main-common.cpp, but this is esp32, not linux.

As in, the other all-clusters apps have to be fixed to call this bit too.

jamesharrow commented 2 months ago

@PeterC1965 is reworking this to move WaterHeater from all-clusters into Energy Management App and then to have a ESP32 and Silabs version which is compatible with Linux.

PR in progress: https://github.com/project-chip/connectedhomeip/pull/34886

jamesharrow commented 2 months ago

Note that https://github.com/CHIP-Specifications/chip-test-plans/issues/4509 has proposed removing the TC-EWATERHTR-1.1 test from the test plan because it is covered by the TC-IDM-10.2 Conformance Testing now.

To confirm - the https://github.com/project-chip/connectedhomeip/pull/34886 has been manually tested on ESP32 to check that this now works with energy management app with water heater logic enabled.