[BUG] Clang-Tidy error

[jlatusek]

Reproduction steps

New version of clang-tidy avaliable with latest pigweed version, found new types of errors:

• bugprone-pointer-arithmetic-on-polymorphic-object - error:

2024-08-19 08:28:29 INFO TIDY ../../src/app/EventManagement.cpp: /mnt/dane/projects/matter/connectedhomeip-second/out/sanitizers/../../src/app/EventManagement.cpp:107:51: error: pointer arithmetic on polymorphic object of type 'CircularEventBuffer' can result in undefined behavior if the dynamic type differs from the pointer type [bugprone-pointer-arithmetic-on-polymorphic-object,-warnings-as-errors]`  
    107 | next = (bufferIndex < aNumBuffers - 1) ? &apCircularEventBuffer[bufferIndex + 1] : nullptr;
            | ^~~~~~~~~~~~~~~~~~~~~
/mnt/dane/projects/matter/connectedhomeip-second/out/sanitizers/../../src/app/EventManagement.cpp:109:20: error: pointer arithmetic on polymorphic object of type 'CircularEventBuffer' can result in undefined behavior if the dynamic type differs from the pointer type [bugprone-pointer-arithmetic-on-polymorphic-object,-warnings-as-errors]
    109 | current = &apCircularEventBuffer[bufferIndex];

• bugprone-suspicious-stringview-data-usage - error: clang-tidy.log

Bug prevalence

always

GitHub hash of the SDK that was being used

ff6863ed127fb1a8a6f134ed15b2ed98ed75e418

Platform

core

Platform Version(s)

No response

Anything else?

No response

[bzbarsky-apple]

@jlatusek Does marking CircularEventBuffer as final silence the warning?

[jlatusek]

@bzbarsky-apple you are right, it silence the warning

[bzbarsky-apple]

Great, a warning that makes sense and goes away when it's not relevant. :) @jlatusek do you want to create that PR, or should I?

[jlatusek]

I will fix that in PR in which I found it #34194

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Remove stale label or comment or this will be closed in 30 days.