[Trivial] emberAfIsTypeSigned doesn't return true for all signed types

project-chip / connectedhomeip

Matter (formerly Project CHIP) creates more connections between more objects, simplifying development for manufacturers and increasing compatibility for consumers, guided by the Connectivity Standards Alliance.

https://buildwithmatter.com

Apache License 2.0

7.34k stars 1.97k forks source link

[Trivial] emberAfIsTypeSigned doesn't return true for all signed types #35147

Closed hasty closed 2 weeks ago

hasty commented 4 weeks ago

Type

Other

Explanation

Namely, ZCL_POWER_MW_ATTRIBUTE_TYPE, ZCL_AMPERAGE_MA_ATTRIBUTE_TYPE, ZCL_VOLTAGE_MV_ATTRIBUTE_TYPE, ZCL_ENERGY_MWH_ATTRIBUTE_TYPE

Platform

all

Platform Version(s)

No response

Testing

Manually tested with SDK

(Optional) If manually tested please explain why this is only manually tested

No response

Anything else?

No response

bzbarsky-apple commented 3 weeks ago

Note that this will become IsSignedIntegerAttribute in https://github.com/project-chip/connectedhomeip/pull/32632