A number of TC test scripts that use Open Commissioning Window use a problematic setup payload

project-chip / connectedhomeip

Matter (formerly Project CHIP) creates more connections between more objects, simplifying development for manufacturers and increasing compatibility for consumers, guided by the Connectivity Standards Alliance.

https://buildwithmatter.com

Apache License 2.0

7.49k stars 2.01k forks source link

A number of TC test scripts that use Open Commissioning Window use a problematic setup payload #35789

Open ksperling-apple opened 1 month ago

ksperling-apple commented 1 month ago

The setup payload MT:-24J0AFN00KA0648G00 and corresponding verifier have been copy / pasted into a number of test scripts. However this payload contains the test vendor ID (0xFFF1), causing a discovery failure during PASE establishment if the DUT is using a real vendor id.

For good measure we should also use a discriminator and passcode that differ from the default values used by the example apps.

ksperling-apple commented 1 month ago

Fixing a few of these in #35784, I'll put up a PR for the rest tomorrow.

ksperling-apple commented 1 month ago

It looks like these tests might be affected:

Test_TC_ACE_1_5.yaml
Test_TC_ACL_2_10.yaml
Test_TC_ACL_2_7.yaml
Test_TC_ACL_2_8.yaml
Test_TC_CADMIN_1_22.yaml
Test_TC_CADMIN_1_24.yaml
Test_TC_CADMIN_1_3.yaml
Test_TC_CADMIN_1_5.yaml

However these all seem to have manual steps or be marked as PICS_SDK_CI_ONLY