search

project-chip / connectedhomeip

Matter (formerly Project CHIP) creates more connections between more objects, simplifying development for manufacturers and increasing compatibility for consumers, guided by the Connectivity Standards Alliance.
https://buildwithmatter.com
Apache License 2.0
7.4k stars 1.98k forks source link

Unify the "device type" structure between ember and codegen data model provider #35889

Open andy31415 opened 4 days ago

andy31415 commented 4 days ago

https://github.com/project-chip/connectedhomeip/pull/35861 introduces DataModel::DeviceTypeEntry which in practice is identical to EmberAfDeviceType.

Figure out a way to share this definition. Ember types are not to be exposed externally (codegen implementation should be the only ember aware code in the long run). DataModel types are global, however we have to consider if we really want to make ember depend on data provider interfaces.

bzbarsky-apple commented 2 days ago

we have to consider if we really want to make ember depend on data provider interfaces

I think that would be absolutely fine.