search

project-chip / connectedhomeip

Matter (formerly Project CHIP) creates more connections between more objects, simplifying development for manufacturers and increasing compatibility for consumers, guided by the Connectivity Standards Alliance.
https://buildwithmatter.com
Apache License 2.0
7.4k stars 1.98k forks source link

Investigate better TLV API to SDK consumer #5447

Open yunhanw-google opened 3 years ago

yunhanw-google commented 3 years ago

I am very worried about exposing the raw TLV to SDK consumers. The TLV reader API is not particularly easy to use, unfortunately. Again, I guess we can do this for the moment, but it seems to me that we're eventually going to want a nicer API. What the size cost of that would be is a hard question, but I would really like something safer to use than "here, read some tlv; good luck", especially when the rules around reading TLV are not well-internalized even by CHIP developers and are not well-described in the spec.

https://github.com/project-chip/connectedhomeip/pull/5198#pullrequestreview-614895525

bzbarsky-apple commented 3 years ago

The real question is whether "here's the TLV for the event list" is the right API at all to expose as an external SDK API.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] commented 1 year ago

This stale issue has been automatically closed. Thank you for your contributions.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.