project-chip / connectedhomeip

Matter (formerly Project CHIP) creates more connections between more objects, simplifying development for manufacturers and increasing compatibility for consumers, guided by the Connectivity Standards Alliance.
https://buildwithmatter.com
Apache License 2.0
7.42k stars 1.99k forks source link

Creation of CommandContext to pass into ZCL layer #752

Closed wehale closed 4 years ago

wehale commented 4 years ago

Problem

The ZCL core-dispatch code assumes the arrival of a decoded APS layer (in Zigbee speak) put into an instance of a CommandContext struct. We'll need this done by someone for the ZCL demo.

Proposed Solution

parse incoming buffer and create command context (pull out APS header info like endpoint, cluster id, command id, manufacturer code, direction etc...) Pass created CommandContext off as a pointer to the ZCL code which will do the rest of the payload processing.

bzbarsky-apple commented 4 years ago

We have an in-tree API (chipZclProcessIncoming), which more or less does this, as far as I can tell. @wehale Is there something else to be done here?

wehale commented 4 years ago

@bzbarsky-apple, I'm looking at the code now and I think chipZclProcessIncoming does this so this issue can be closed.