project-chip / connectedhomeip

Matter (formerly Project CHIP) creates more connections between more objects, simplifying development for manufacturers and increasing compatibility for consumers, guided by the Connectivity Standards Alliance.
https://buildwithmatter.com
Apache License 2.0
7.48k stars 2.01k forks source link

Checked in generated code is large and causes merge and review problems #7720

Closed andy31415 closed 2 years ago

andy31415 commented 3 years ago

Problem

The reason we check in generated code is that ZAP tool itself seems to not be easily integrated into build system: compling a C++ library and requring nodejs is very heavy and zap seems to require UI because it is an electron app, even if running headless.

Proposed Solution

Figure out how to separate out code generation and not be part of the main repository. We may still want to provide an option for anyone bringing chip into internal builds (which will not have nodjs or UI toolkits installed) to generate code and use it separately, however main reviews should not deal with generated code at all and it should be part of the build.

It would be best if the build system itself would do code generation without requiring UI or large dependencies. This likely means 'python code generation'.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] commented 2 years ago

This stale issue has been automatically closed. Thank you for your contributions.