project-chip / matter-test-scripts

Test scripts related to Matter Certification
https://csa-iot.org/
Apache License 2.0
9 stars 3 forks source link

[TC-OPCREDS-3.2] - steps_TC_OPCREDS_3_2 method does NOT follow expected TH parser template #268

Open rquidute opened 3 months ago

rquidute commented 3 months ago

Description:

The steps_TC_OPCREDS_3_2 method is not following the current TH parser template since the description argument for TestStep are using formatted string and methods, instead it should only use plain text for method descriptions.

For example :

 TestStep(1, f"{commission_from_existing('CR1', 'CR2')}\n. Save the FabricIndex from the NOCResponse as `fabric_index_CR2`.",
                         verify_commissioning_successful())

This step above should be written in a way to avoid formatted string and method, so it might be re-written to:

 TestStep(1, "Commission from existing CR1 or CR2\n. Save the FabricIndex from the NOCResponse as `fabric_index_CR2`.",
"Verify the commissioning is successful.")
cecille commented 3 months ago

uh...why? The function returns a well formatted string.

rquidute commented 3 months ago

The TH python test parser does not Load the python script, so TH don't call for steps_[Test_case] method , instead it reads the python script file using the ast and then it gets the value from the content inside the method.

cecille commented 3 months ago

What does this test do?https://github.com/project-chip/connectedhomeip/blob/master/src/python_testing/TC_DA_1_7.py

rquidute commented 3 months ago

Backend does not crash but only Commission DUT if not already done step is being displayed