search

project-chip / matter.js

A complete typescript implementation of the Matter protocol specification (https://buildwithmatter.com). Includes full support for controller, device, commissioning, secure communications, device types, and cluster definitions.
Apache License 2.0
346 stars 59 forks source link

Check for both Wifi and Ethernet in Step 11 during the commissioning process #1107

Closed digitaldan closed 2 months ago

digitaldan commented 2 months ago

Fixes #1106

semanticdiff-com[bot] commented 2 months ago

Review changes with SemanticDiff.

Analyzed 1 of 1 files.

Overall, the semantic diff is 40% smaller than the GitHub diff.

Filename Status
:heavy_check_mark: packages/matter.js/src/protocol/ControllerCommissioner.ts 39.31% smaller
Apollon77 commented 2 months ago

Please see my comment on the issue. This change makes no sense because it would accept any not connected WiFi or thread cluster as ok. This check is there to verify if we can commission it when WiFi or thread is not connected.

Apollon77 commented 2 months ago

According to discussion in #1106 and the (in my eyes) better solution in #1109 I close here. Thank you anyway for your support and PR!