search

project-chip / matter.js

A complete typescript implementation of the Matter protocol specification (https://buildwithmatter.com). Includes full support for controller, device, commissioning, secure communications, device types, and cluster definitions.
Apache License 2.0
328 stars 57 forks source link

Skip network commissioning when devcie is already on IP network #1109

Closed Apollon77 closed 3 weeks ago

Apollon77 commented 3 weeks ago

This PR adjusts the Commissioner to skip the Commissioning checks when the device connection already is on IP network

@digitaldan Could you check if this change fixes your issue and so support in review? Thank you

fixes #1106

semanticdiff-com[bot] commented 3 weeks ago

Review changes with SemanticDiff.

Analyzed 9 of 9 files.

Overall, the semantic diff is 41% smaller than the GitHub diff.

Filename Status
:heavy_check_mark: packages/matter.js-react-native/src/ble/ReactNativeBleChannel.ts Analyzed
:heavy_check_mark: packages/matter.js/src/protocol/ControllerCommissioner.ts 81.82% smaller
:heavy_check_mark: packages/matter.js/src/protocol/ExchangeManager.ts Analyzed
:heavy_check_mark: packages/matter.js/src/protocol/interaction/InteractionClient.ts Analyzed
:heavy_check_mark: packages/matter.js/src/net/UdpInterface.ts Analyzed
:heavy_check_mark: packages/matter.js/src/common/Channel.ts Analyzed
:heavy_check_mark: packages/matter.js/src/ble/Ble.ts Analyzed
:heavy_check_mark: packages/matter-node-ble.js/src/ble/BlenoBleServer.ts Analyzed
:heavy_check_mark: packages/matter-node-ble.js/src/ble/NobleBleChannel.ts Analyzed