search

project-chip / rs-matter

Rust implementation of the Matter protocol. Status: Experimental
Apache License 2.0
310 stars 43 forks source link

[mdns] Fix multicast routing error on esp32 (and likely other platforms) #110

Closed jasta closed 11 months ago

jasta commented 11 months ago

According to the RFC (https://datatracker.ietf.org/doc/html/rfc2553#section-3.3), it is necessary to disambiguate link-local addresses with the interface index (in the scope_id field). Lacking this field, newer versions of lwip that support proper IPv6 scopes will yield EHOSTUNREACH (Host unreachable). Other implementations like on Linux and OS X will likely be affected by the lack of this field for more complex networking setups.

Fixes #100

CLAassistant commented 11 months ago

CLA assistant check
All committers have signed the CLA.

jasta commented 11 months ago

hehe, cargo clippy checks fail then when I run cargo clippy --fix the build fails. Oh rust :)

jasta commented 11 months ago

@ivmarkov I'm guessing you don't have merge access? Is that only @kedars that can?

ivmarkov commented 11 months ago

Yes, only @kedars

jasta commented 11 months ago

@kedars is there anything more for me to do on this PR? I think you have to push the merge button. At least, I don't see any option to merge.