I am looking to move to syn2 and started re-structuring code (very deep nesting). While doing this, I found that the "unordered" branch was not correct: it was checking for a "NameValue" pair, however because unordered shows as a keyword it was not a pair at all. I fixed that bug and am proposing this PR for now for the fix.
I expect a followup that moves the entire thing to syn2 (so I can match the syn requirements for macros-impl and then we can move these things to macros-impl and have unit tests.
Testing
ran unit tests and they still pass. Validated that if I remove any handling logic the tests fail (EXCEPT unordered, which was not working anyway ... this means we do not test unordered, not sure what to do there).
I am looking to move to syn2 and started re-structuring code (very deep nesting). While doing this, I found that the "unordered" branch was not correct: it was checking for a "NameValue" pair, however because unordered shows as a keyword it was not a pair at all. I fixed that bug and am proposing this PR for now for the fix.
I expect a followup that moves the entire thing to syn2 (so I can match the syn requirements for macros-impl and then we can move these things to macros-impl and have unit tests.
Testing