search

project-chip / rs-matter

Rust implementation of the Matter protocol. Status: Experimental
Apache License 2.0
310 stars 43 forks source link

Multiple improvements to the exchange and transport layers #147

Closed ivmarkov closed 4 months ago

ivmarkov commented 5 months ago

@kedars @andreilitvin

This is a very large PR indeed so I would assume it will take a while to comprehend.

Some of the design decisions in the PR might be subject to debate, or at the very least - they might need explanations, clarifications and feedback.

Therefore, I've created an informal RFC of sorts which I uploaded to HackMD: https://hackmd.io/@ivmarkov/SyHoBnpA6 (It is also checked-in in GitHub as part of this PR)

Please look at the doc, as it tries to summarize the main deficiencies of the existing transport layer that this PR is addressing, as well as how it tries to address those. Commenting in the doc should be enabled as long as you sign in to HackMD. Let me know if commenting does not work for you.

(BTW: I'm also fine with chopping the PR into smaller chunks, as long as we find a way to do it, as the changes are highly inter-related.)

ivmarkov commented 4 months ago

@andreilitvin I've tried to address all your feedback so far. I've either made code changes, or commented where I feel code changes are not appropriate.

I've marked all your feedback as resolved only so that you can track where I've taken action (basically and as per above - now everywhere).

If you feel some items require further discussion, please "unresolve" those. Or open new feedback items wherever you find appropriate.