project-chip / rs-matter

Rust implementation of the Matter protocol. Status: Experimental
Apache License 2.0
303 stars 43 forks source link

Remove all sessions and subscriptions on fabric removal #183

Closed ivmarkov closed 1 month ago

ivmarkov commented 1 month ago

This PR also fixes https://github.com/project-chip/rs-matter/issues/182, but that's because the fallback code-path where - in the absence of a valid session ID - we search (and potentially create) a session by fab-idx + peer node ID, is now (temporarily) commented out.

I think we should restore the fallback logic back to life once we know how exactly to find (or create) a session for reporting which is different from the original one.

For now, reporting only thru the original session is seemingly good enough. The peer node would anyway resubscribe if the session is over and it does not receive a subscription response within the provided timeout (which most of the time seems to be one minute).

ivmarkov commented 1 month ago

Let me check why some tests did fail...