project-chip / rs-matter

Rust implementation of the Matter protocol. Status: Experimental
Apache License 2.0
323 stars 45 forks source link

[Copyright] Update all copyright headers #190

Open ivmarkov opened 3 months ago

ivmarkov commented 3 months ago

We need to update all copyright headers as they currently say "Copyright 2020 - 2022..." and 2022 is in the past.

Is the CSA alliance having any prescriptions here? If not:

@andreilitvin mentioned the C++ SDK has a policy to put newer copyright only in the files they newly add (or change?) BUT I do not understand this policy at all.

Copyright headers of all files - old or new always need to be up to date. Always. Not a lawyer, but pretty sure about that. Otherwise it would look as if the copyright of the old files had expired, which is just not the case.

Two options I can think of:

What to do with the beginning year? Also two options:

ivmarkov commented 3 months ago

@kedars ^^^

kedars commented 3 months ago

@andreilitvin are there any project-chip-wide policies that are being followed by other repos?

jwhui commented 3 months ago

Copyright generally applies at the time of creation. The year clarifies when that creation occurred. Updating the copyright year generally occurs when new creative input was made.

kedars commented 3 months ago

Copyright generally applies at the time of creation. The year clarifies when that creation occurred. Updating the copyright year generally occurs when new creative input was made.

That aligns with my understanding too.

So @ivmarkov the option to choose would be to update the year after the - whenever the particular file is updated.

ivmarkov commented 3 months ago

@kedars OK just to confirm on 100%:

Right?

andy31415 commented 3 months ago

Let's start with: new files should have the current year (unless copied and pasted file content or rename).

Beyond that, I would like to reduce developer churn work as much as possible while still making lawyers happy. Currently I am not commenting on year changes on existing files, only remarked that if we create a new file we can add the current year.

ivmarkov commented 3 months ago

Let's start with: new files should have the current year (unless copied and pasted file content or rename).

Beyond that, I would like to reduce developer churn work as much as possible while still making lawyers happy. Currently I am not commenting on year changes on existing files, only remarked that if we create a new file we can add the current year.

Here's a plan forward:

kedars commented 3 months ago

Here's a plan forward:

Sounds good to me

Start year: 2022 (it is 2020 now). The earliest commit in the repo seems to be from Dec 12 2022. Or shall we just do 2023? @kedars Is it true that you guys started in 2022, or do I have it wrong and you've worked in another repo before that?

Let's keep it as 2021, I was working on a personal repo since 2021. The initial commit to this repo squashed everything since then into a single commit