search

project-codeflare / codeflare-operator

Operator for installation and lifecycle management of CodeFlare distributed workload stack
Apache License 2.0
7 stars 43 forks source link

Upgrade to go 1.21 #541

Closed dgrove-oss closed 5 months ago

dgrove-oss commented 6 months ago

This pulls out the upgrade to Go 1.21 (required by Kueue and AppWrapper) from #491 into a standalone PR. Hopefully this makes it easier to handle the downstream build system changes needed for the go update without the additional complexity of simultaneously adding the AppWrapper CRD and controller.

Obviously, this PR should be held until the downstream repos are ready to make the needed changes, but should be merged before we start working on the remaining pieces of #491.

astefanutti commented 6 months ago

/lgtm

astefanutti commented 6 months ago

/hold

Making sure everything is setup downstream.

dgrove-oss commented 6 months ago

rebased to resolve conflict in Dockerfile

dgrove-oss commented 5 months ago

rebased yet again.

astefanutti commented 5 months ago

/unhold

astefanutti commented 5 months ago

/approve

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti, jiripetrlik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/project-codeflare/codeflare-operator/blob/main/OWNERS)~~ [astefanutti] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
astefanutti commented 5 months ago

/lgtm