project-codeflare / codeflare-operator

Operator for installation and lifecycle management of CodeFlare distributed workload stack

Apache License 2.0

7 stars 41 forks source link

Generate AppWrapper name in tests to provide unique workloads #591

Closed sutaakar closed 2 months ago

sutaakar commented 2 months ago

Issue link

N/A

What changes have been made

Generating AppWrapper name to make sure that AppWrappers are unique to avoid reconciliation issues.

Verification steps

PR checks pass reliably.

Checks

[ ] I've made sure the tests are passing.
Testing Strategy
- [ ] Unit tests
- [ ] Manual tests
- [ ] Testing is not required for this change

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from sutaakar. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/project-codeflare/codeflare-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

dgrove-oss commented 2 months ago

We haven't considered wrapping resources that use GenerateName. Looking to see if it is easily fixable...

dgrove-oss commented 2 months ago

I updated #588 to pick up AppWrapper 0.21.1 which has the fix for generateNames. Not sure how best to merge the 2 PRs

sutaakar commented 2 months ago

Will merge your PR first, then update this PR to use generated names for resources