project-codeflare / codeflare-operator

Operator for installation and lifecycle management of CodeFlare distributed workload stack

Apache License 2.0

7 stars 41 forks source link

Adjust e2e tests to verify deletion of resources #592

Closed sutaakar closed 2 months ago

sutaakar commented 2 months ago

Issue link

What changes have been made

Expand e2e tests to verify that resource deletion is successful. Side reason for this change is to make sure e2e tests are stable as it seems that deleting Workload resources, local queue and namespace at the same time can lead to race condition when ClusterQueue is not properly updated, causing Workloads to hang.

Verification steps

Verified by running e2e tests locally.

Checks

[x] I've made sure the tests are passing.
Testing Strategy
- [x] Unit tests
- [x] Manual tests
- [ ] Testing is not required for this change

sutaakar commented 2 months ago

/approve

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiripetrlik, sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/project-codeflare/codeflare-operator/blob/main/OWNERS)~~ [sutaakar] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment