Closed KPostOffice closed 2 months ago
Ideally the existing resources should be pruned, like during the operator upgrade. But I think that's acceptable.
I had this thought too. I can try my hand at writing an upgrade strategy for this
I guess the new names should be reflected into Ray cluster the webhook.
Overall LGTM, just left a comment on the hash seed, and to update the Ray cluster webhook accordingly.
I guess the new names should be reflected into Ray cluster the webhook.
I think this is taken care of already by using the nameFromCluster
functions in all the necessary places.
I guess the new names should be reflected into Ray cluster the webhook.
I think this is taken care of already by using the
nameFromCluster
functions in all the necessary places.
Ah OK, I thought it could explain why the e2e failed.
I guess the new names should be reflected into Ray cluster the webhook.
I think this is taken care of already by using the
nameFromCluster
functions in all the necessary places.Ah OK, I thought it could explain why the e2e failed.
The tests also needed to be changed to use the fromCluster
functions. I'm still messing around with them. I thought I caught everything but I'm still clearly missing something that needs to be fixed in the tests
@astefanutti This should be g2g now
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: astefanutti
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Issue link
https://issues.redhat.com/browse/RHOAIENG-10129
What changes have been made
created a function which takes a string and appends the controller name to it then hashes it to use as a suffix for the resources created by this controller to avoid naming conflicts
Verification steps
Checks