search

project-codeflare / codeflare-operator

Operator for installation and lifecycle management of CodeFlare distributed workload stack
Apache License 2.0
7 stars 45 forks source link

add hash to end of resource names to avoid name clash #605

Closed KPostOffice closed 2 months ago

KPostOffice commented 3 months ago

Issue link

https://issues.redhat.com/browse/RHOAIENG-10129

What changes have been made

created a function which takes a string and appends the controller name to it then hashes it to use as a suffix for the resources created by this controller to avoid naming conflicts

Verification steps

Checks

KPostOffice commented 3 months ago

Ideally the existing resources should be pruned, like during the operator upgrade. But I think that's acceptable.

I had this thought too. I can try my hand at writing an upgrade strategy for this

astefanutti commented 3 months ago

I guess the new names should be reflected into Ray cluster the webhook.

astefanutti commented 3 months ago

Overall LGTM, just left a comment on the hash seed, and to update the Ray cluster webhook accordingly.

KPostOffice commented 3 months ago

I guess the new names should be reflected into Ray cluster the webhook.

I think this is taken care of already by using the nameFromCluster functions in all the necessary places.

astefanutti commented 3 months ago

I guess the new names should be reflected into Ray cluster the webhook.

I think this is taken care of already by using the nameFromCluster functions in all the necessary places.

Ah OK, I thought it could explain why the e2e failed.

KPostOffice commented 3 months ago

I guess the new names should be reflected into Ray cluster the webhook.

I think this is taken care of already by using the nameFromCluster functions in all the necessary places.

Ah OK, I thought it could explain why the e2e failed.

The tests also needed to be changed to use the fromCluster functions. I'm still messing around with them. I thought I caught everything but I'm still clearly missing something that needs to be fixed in the tests

KPostOffice commented 3 months ago

@astefanutti This should be g2g now

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/project-codeflare/codeflare-operator/blob/main/OWNERS)~~ [astefanutti] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment