project-codeflare / codeflare-operator

Operator for installation and lifecycle management of CodeFlare distributed workload stack

Apache License 2.0

7 stars 45 forks source link

Add creation of kueue resources in e2e tests #616

Closed ChughShilpa closed 1 month ago

ChughShilpa commented 2 months ago

Issue link

RHOAIENG-11047

What changes have been made

Since we are adjusting e2e tests to run with AMD gpu, thus

Adding creation of kueue resources as part of test to make it compatible with gpuresources (which is covered in next PR)
Removing creation of kueue resources from setup script
Adjust methods with updated Ray cluster client

Verification steps

Run test manually go test -timeout 30m -v ./test/e2e -run TestMnistPyTorchAppWrapperCpu

Checks

[ ] I've made sure the tests are passing.
Testing Strategy
- [ ] Unit tests
- [X] Manual tests
- [ ] Testing is not required for this change

ChughShilpa commented 1 month ago

@sutaakar @astefanutti Could someone please approve the PR ?

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/project-codeflare/codeflare-operator/blob/main/OWNERS)~~ [astefanutti] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

sutaakar commented 1 month ago

We may want to think about a strategy for the creation of cluster resources like ClusterQueues in the context of concurrent execution of tests in the future.

Current strategy is to provide generated name for cluster resources.