search

project-codeflare / codeflare-operator

Operator for installation and lifecycle management of CodeFlare distributed workload stack
Apache License 2.0
7 stars 45 forks source link

Add RBAC aggregator cluster roles for appwrappers #623

Closed dgrove-oss closed 3 weeks ago

dgrove-oss commented 3 weeks ago

@Bobbins228

Please validate that added clusterroles get properly propagated through the downstream builds to RHOAI. I don't have visibility into that process.

Bobbins228 commented 3 weeks ago

@dgrove-oss On next release the changes will be automatically propagated downstream but I will keep an eye on that just in case :+1:

sutaakar commented 3 weeks ago

/lgtm Used https://github.com/project-codeflare/codeflare-operator/pull/624 to check that namespaced admin can work with AppWrapper by default.

sutaakar commented 3 weeks ago

/approve

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/project-codeflare/codeflare-operator/blob/main/OWNERS)~~ [sutaakar] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment