project-codeflare / codeflare

Simplifying the definition and execution, scaling and deployment of pipelines on the cloud.
https://codeflare.dev
Apache License 2.0
218 stars 35 forks source link

Replace SimlpleQueue #15

Closed raghukiran1224 closed 3 years ago

raghukiran1224 commented 3 years ago

Overview

Currently, lineage uses SimpleQueue to realize pipelines. But this is available only in Python >=3.8. This reduces adoption, moving to Queue will give us broader Python version coverage.

Acceptance Criteria

Questions

Assumptions

Reference

aviolante commented 3 years ago

@raghukiran1224 is this just a matter of from queue import Queue in the Runtime.py file and then changing lines 377 and 414 from xyref_queue = SimpleQueue() to xyref_queue = Queue()

raghukiran1224 commented 3 years ago

@aviolante Perfect, thanks for the pointer :) Do you want to create a PR and be our first outside contributor? :)

raghukiran1224 commented 3 years ago

@aviolante lol.. I just noticed you already did!

aviolante commented 3 years ago

@raghukiran1224 haha

raghukiran1224 commented 3 years ago

validated on WS Python notebook and example works in a vanilla environment after pip3 install --upgrade pip and pip3 install codeflare==0.1.2, which is also the default now.