project-codeflare / codeflare

Simplifying the definition and execution, scaling and deployment of pipelines on the cloud.
https://codeflare.dev
Apache License 2.0
222 stars 36 forks source link

Predicted output is not properly assigned to get_yref(), instead is assigned to get_Xref() #22

Closed raghukiran1224 closed 3 years ago

raghukiran1224 commented 3 years ago

Describe the bug After running a PREDICT, the y_predcannot be obtained via get_yref(), instead can be obtained via the get_Xref(). Semantically, this seems weird.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://github.ibm.com/codeflare/ray-pipeline/blob/complex-example-1/notebooks/plot_feature_selection_pipeline.ipynb
  2. Scroll down to `y_pred = ray.get(predict_clf_output[0].get_yref())
  3. If you change that statement to y_pred = ray.get(predict_clf_output[0].get_Xref()) the output would match the original sklearn pipeline on the top.

Expected behavior The predicted output should be obtained from calling get_yref().

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

raghukiran1224 commented 3 years ago

Created by @klwuibm

klwuibm commented 3 years ago

closing this issue.