project-codeflare / instascale

On-demand Kubernetes/OpenShift cluster scaling and aggregated resource provisioning
Apache License 2.0
10 stars 20 forks source link

add: integration with helm for deployment #114

Closed VanillaSpoon closed 1 year ago

VanillaSpoon commented 1 year ago

Issue link

fixes #12

What changes have been made

This PR integrates helm to manage the deployment process of instascale. This change is in line with the current deployment process of MCAD and aims to bring more consistency across the projects.

This pr also updates the documentation regarding deployment.

Verification steps

When deploying instascale to an OSD cluster:

cd deployment 
helm install instascale instascale

Then check to ensure each of the following have been deployed correctly and are operational: instascale-configmap instascale-sa instascale-crb instascale-cr instascale

Checks

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign asm582 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/project-codeflare/instascale/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
anishasthana commented 1 year ago

I get going for consistency, but imo we should still push for using only the operator for instascale installation. With MCAD, the helm charts are around from before the operator being a thing.