search

project-codeflare / instascale

On-demand Kubernetes/OpenShift cluster scaling and aggregated resource provisioning
Apache License 2.0
10 stars 20 forks source link

Upgrade MCAD to latest version #121

Closed astefanutti closed 1 year ago

astefanutti commented 1 year ago

This PR upgrades to the latest version of MCAD containing the upgrade to Kubernetes 1.26: project-codeflare/multi-cluster-app-dispatcher#552.

The main impacts are the required upgrade of the controller-runtime dependency to a compatible version, i.e., v0.14, and the upgrade to Golang 1.19.

astefanutti commented 1 year ago

Great start, upgrading go would make it LGTM.

@z103cb Go upgraded to 1.19 with 11f8d471e4ef7669f5b88e3b6c2039e9fb09b15f.

asm582 commented 1 year ago

Thanks, @astefanutti! curios, are we planning to run manual e2e tests?

astefanutti commented 1 year ago

Thanks, @astefanutti! curios, are we not running e2e tests?

@asm582 not directly from here (yet), plus we need to work on the e2e tests that'd cover InstaScale specifically.

asm582 commented 1 year ago

Thanks, @astefanutti! curios, are we not running e2e tests?

@asm582 not directly from here (yet), plus we need to work on the e2e tests that'd cover InstaScale specifically.

ok, thanks

/approve

z103cb commented 1 year ago

/Approve

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asm582, z103cb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/project-codeflare/instascale/blob/main/OWNERS)~~ [asm582] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment