search

project-codeflare / instascale

On-demand Kubernetes/OpenShift cluster scaling and aggregated resource provisioning
Apache License 2.0
10 stars 20 forks source link

fix: allow for download of kustomize from the makefile #135

Closed VanillaSpoon closed 1 year ago

VanillaSpoon commented 1 year ago

Issue link

134

What changes have been made

This pr fixes contains the addition of go-get-tool to download kustomize and setup-envtest if they are not currently locally installed.

It also contains a change to the declaration of the image to use for deployment. The image was being set to controller:latest when running make deploy. It will now be set to quay.io/project-codeflare/instascale-controller:latest

Verification steps

Previously: Within instascale, go to /bin and delete your kustomize binary. Then from the root folder, run make kustomize. The Kustomize binary will not have been downloaded.

This branch: Within instascale, go to /bin and delete your kustomize binary. Then from the root folder, run make kustomize. The Kustomize binary will be downloaded.

Checks

asm582 commented 1 year ago

/LGTM

astefanutti commented 1 year ago

/lgtm

astefanutti commented 1 year ago

/approve

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti, Bobbins228

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/project-codeflare/instascale/blob/main/OWNERS)~~ [astefanutti] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment