project-codeflare / instascale

On-demand Kubernetes/OpenShift cluster scaling and aggregated resource provisioning

Apache License 2.0

10 stars 20 forks source link

Expose structured configuration #136

Closed astefanutti closed 1 year ago

astefanutti commented 1 year ago

Issue link

Closes #132

What changes have been made

Expose a structured configuration API
Adapt main.go to use the structured configuration

Verification steps

Start InstaScale, make sure it works as expected.

astefanutti commented 1 year ago

/assign @anishasthana @asm582

anishasthana commented 1 year ago

/hold (I want to make sure we get the codeflare-sdk hotfix release out before this is merged in)

anishasthana commented 1 year ago

/unhold

VanillaSpoon commented 1 year ago

Hey, the pkg/config directory is not being copied into the Docker image during the build process causing the build command to fail.

Just a quick change to the Dockerfile:

# Copy the go source
COPY main.go main.go
COPY controllers/ controllers/
+ COPY pkg/ pkg/

astefanutti commented 1 year ago

@VanillaSpoon great catch, thanks! Fixed in 0c0fa548c3a8fd25e7ae1fb0e4d6a5ff508dab4c.

asm582 commented 1 year ago

/LGTM

VanillaSpoon commented 1 year ago

/lgtm also :)

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/project-codeflare/instascale/blob/main/OWNERS)~~ [anishasthana] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment