search

project-codeflare / instascale

On-demand Kubernetes/OpenShift cluster scaling and aggregated resource provisioning
Apache License 2.0
10 stars 20 forks source link

Ensure deployment of configmap, and ocm-secret permissions. #139

Closed VanillaSpoon closed 1 year ago

VanillaSpoon commented 1 year ago

Issue link

138

What changes have been made

This pr contains adjustments which deploy necessary configurations for the operation of instascale, including the configmap and instascale-ocm-secret resource permissions.

Verification steps

From an old branch:

  1. Run make deploy to deploy Instascale.
  2. Add your instascale-ocm-secret
  3. Check the pod logs, and there will be a message stating the configmap has not been deployed.
  4. Deploy the Instascale configmap independently.
  5. Instascale will be unable to find the OCM secret and will automatically switch to machinesets. Even if an ocm secret is added.
  6. Run make undeploy

From this branch:

  1. Run make deploy to deploy Instascale.
  2. Add your instascale-ocm-secret.
  3. Check the pod logs, and the configmap and OCM secret should be found correcly.

Checks

astefanutti commented 1 year ago

/lgtm

astefanutti commented 1 year ago

/approve

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/project-codeflare/instascale/blob/main/OWNERS)~~ [astefanutti] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment