search

project-codeflare / instascale

On-demand Kubernetes/OpenShift cluster scaling and aggregated resource provisioning
Apache License 2.0
10 stars 20 forks source link

Remove scale-down info for Appwrappers that didn't require a scale-up #175

Closed VanillaSpoon closed 9 months ago

VanillaSpoon commented 1 year ago

WHY

If an appwrapper has an empty ordered instance label, Instascale will be unable to scaleup. This is to be expected, and a log notifies the user of the behaviour

appwrapper_controller.go:248] Found AW <aw-name> that cannot be scaled due to missing orderedinstance label

Upon deleting the appwrapper, you'll be notified of a scale down, even though there are no resources to scale down. 

Appwrapper deleted scale-down node pool: <aw-name>

This is minor, however, may lead to confusion

DONE

If an appwrapper does not require resources to scale up, ensure there is no logging suggesting a scaledown.