project-codeflare / instascale

On-demand Kubernetes/OpenShift cluster scaling and aggregated resource provisioning

Apache License 2.0

10 stars 19 forks source link

remove: unused functions #183

Closed VanillaSpoon closed 10 months ago

VanillaSpoon commented 10 months ago

What changes have been made

This pr contains the removal of unused functions and tests within instascale.

Including:

checkExistingMachineSet
getPodResourcesWithReplicas
MachineClientOrDie
NewClientBuilder
GetListOfPodResourcesFromOneGenericItem
getRestConfig
And their related unit tests

Verification steps

Checks

[ ] I've made sure the tests are passing.
Testing Strategy
- [ ] Unit tests
- [ ] Manual tests
- [ ] Testing is not required for this change

asm582 commented 10 months ago

thanks for cleaning up the functions. I would like to think most functions are deprecated and similar functionality exists in the modified codebase.

/LGTM

openshift-ci[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KPostOffice, sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/project-codeflare/instascale/blob/main/OWNERS)~~ [sutaakar] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment