project-codeflare / instascale

On-demand Kubernetes/OpenShift cluster scaling and aggregated resource provisioning

Apache License 2.0

10 stars 20 forks source link

use context to create new loggers #184

Closed KPostOffice closed 11 months ago

KPostOffice commented 11 months ago

Issue link

https://github.com/project-codeflare/codeflare-operator/issues/113

What changes have been made

Use the controller runtime logger everywhere with structured logging. The logger is generated based on the current context object. In the linked issue there is talk about using .WithName but I'm unsure if this is necessary.

Verification steps

Run controller and see new structured logs.

Checks

[ ] I've made sure the tests are passing.
Testing Strategy
- [ ] Unit tests
- [ ] Manual tests
- [ ] Testing is not required for this change

astefanutti commented 11 months ago

/lgtm

VanillaSpoon commented 11 months ago

/lgtm thanks @KPostOffice :)

astefanutti commented 11 months ago

/lgtm

astefanutti commented 11 months ago

/approve

openshift-ci[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/project-codeflare/instascale/blob/main/OWNERS)~~ [astefanutti] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment