search

project-codeflare / instascale

On-demand Kubernetes/OpenShift cluster scaling and aggregated resource provisioning
Apache License 2.0
10 stars 19 forks source link

Setup kubebuilder to run functional-tests in release workflow #200

Closed ChristianZaccaria closed 7 months ago

ChristianZaccaria commented 7 months ago

Issue link

What changes have been made

The instascale-release.yml workflow is running all tests including the functional-tests ones without performing any setup for it: https://github.com/project-codeflare/instascale/blob/main/.github/workflows/instascale-release.yml#L54

We can see in the functional-test workflow that the steps for downloading kubebuilder and setting it up is necessary before running the functional-tests, for that reason it is failing. We could probably add the above highlighted fields in our release workflow and it should pass.

Verification steps

Checks

sutaakar commented 7 months ago

I think it may be enough to change Test step to run go test -v ./controllers. The functional tests are executed for PR check when dependencies are upgraded, I think it is not necessary to run the test twice.

sutaakar commented 7 months ago

Or maybe to drop tests from release workflow completely, to rely on PR check.

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/project-codeflare/instascale/blob/main/OWNERS)~~ [sutaakar] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment