project-codeflare / multi-cluster-app-dispatcher

Holistic job manager on Kubernetes

Apache License 2.0

108 stars 63 forks source link

Stop CI Build when e2e test case fails #607

Closed Srihari1192 closed 1 year ago

Srihari1192 commented 1 year ago

Issue link

closes https://github.com/project-codeflare/multi-cluster-app-dispatcher/issues/595

What changes have been made

Added ginkgo failfast condition to stop the build when the e2e ginkgo test fails to save build time.

Verification steps

Checks

[x] I've made sure the tests are passing.
Testing Strategy
- [ ] Unit tests
- [ ] Manual tests
- [ ] Testing is not required for this change

Srihari1192 commented 1 year ago

Tested this changes with test failure build and build stops running when test fails https://github.com/Srihari1192/multi-cluster-app-dispatcher/actions/runs/5973170838/job/16204931872#step:7:696

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asm582

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/project-codeflare/multi-cluster-app-dispatcher/blob/main/OWNERS)~~ [asm582] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment