search

project-codeflare / multi-cluster-app-dispatcher

Holistic job manager on Kubernetes
Apache License 2.0
108 stars 63 forks source link

reduce preempt speed #621

Closed asm582 closed 1 year ago

asm582 commented 1 year ago

Issue link

620

What changes have been made

We have used DISPATCH_RESOURCE_RESERVATION_TIMEOUT to slowdown preemption based on dispatched condition timestamp

Verification steps

Manual tests

Checks

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from asm582. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/project-codeflare/multi-cluster-app-dispatcher/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
metalcycling commented 1 year ago

This seems unnecesary given that schedulingSpec.requeuing.timeInSeconds does exactly the same thing. You can set that value and MCAD would wait timeInSeconds seconds before initiating preemption and requeuing. Are we sure we want to have two mechanisms to do this?